-
Notifications
You must be signed in to change notification settings - Fork 169
GH-2979 Allow query explanation via REST API #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
99edfc9
to
143ce8e
Compare
c0e40c4
to
1ab08af
Compare
...er-spring/src/main/java/org/eclipse/rdf4j/http/server/repository/ExplainQueryResultView.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/rdf4j/http/server/repository/handler/AbstractQueryRequestHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/rdf4j/http/server/repository/handler/DefaultQueryRequestHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/rdf4j/http/server/repository/handler/AbstractQueryRequestHandler.java
Outdated
Show resolved
Hide resolved
Does this in any way allow a remote repo (HTTPRepository) to use the existing query explanation method on a query object and retrieve the explanation from the remote server? |
@hmottestad I think answer is yes. Add a method in rdf4j/core/http/client/src/main/java/org/eclipse/rdf4j/http/client/RDF4JProtocolSession.java Lines 241 to 256 in b33d914
|
Serialisation would be the main issue then I guess. Let me just have a little think to see if there could be any potential issues down the line. |
f6d9d9b
to
eaddc96
Compare
@hmottestad Hey, let's only include the rest api in this PR. I will have some future work on HttpRepo and workbench to utilize this api. |
Code looks good! Thanks! The final thing I need to do is test this locally just to see how it looks. |
GitHub issue resolved: #
#2979
Briefly describe the changes proposed in this PR:
Add an additional parameter to the query endpoint. If parm
explain
is present, don't execute the query and return the query explaination instead.Currently only supports Text and Json response format.
Requst to return Json
Request to return plain text
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)