-
Notifications
You must be signed in to change notification settings - Fork 169
GH-3654 Support for JSON-LD 1.1 #4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eea6db9
to
c8a3d09
Compare
4010ad8
to
b080f33
Compare
81037f9
to
8ef2367
Compare
54b035e
to
4aa5b21
Compare
63b8575
to
e33e895
Compare
TODO:
|
e33e895
to
63d1cd2
Compare
876adaf
to
029961e
Compare
029961e
to
9773b80
Compare
hmottestad
commented
Mar 8, 2024
@@ -32,6 +32,7 @@ | |||
import java.io.OutputStreamWriter; | |||
import java.io.Reader; | |||
import java.io.Writer; | |||
import java.nio.charset.StandardCharsets; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo: Optimize imports
...ld-legacy/src/main/java/org/eclipse/rdf4j/rio/jsonld/legacy/JSONLDHierarchicalProcessor.java
Outdated
Show resolved
Hide resolved
...d-legacy/src/test/java/org/eclipse/rdf4j/rio/jsonld/legacy/JSONLDHierarchicalWriterTest.java
Outdated
Show resolved
Hide resolved
1aaa5de
to
12c220b
Compare
78adddd
to
3cb97d1
Compare
Develop branch
This branch
Develop branch is faster at writing JSON-LD. Might be worth looking into, but the difference isn't too bad. |
3cb97d1
to
c396d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #3654
Briefly describe the changes proposed in this PR:
jsonld-legacy
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)