Skip to content

Conversation

@elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 1, 2025

Notes for Reviewer

This PR moves iox2/legacy/duration.hpp and its dependencies to iox2/bb/duration.hpp. Furthermore, the namespace is adjusted to iox2::bb and the clang-tidy warnings are fixed.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • [~] Tests follow the best practice for testing
  • [~] Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

PR Reviewer Reminder

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #301

@elBoberido elBoberido marked this pull request as draft December 1, 2025 02:07
elfenpiff
elfenpiff previously approved these changes Dec 1, 2025
@elBoberido elBoberido force-pushed the iox2-301-move-into-files-to-iox2-bb branch from 54141ea to 4a82879 Compare December 1, 2025 18:00
@elBoberido elBoberido force-pushed the iox2-301-move-duration-files-to-iox2-bb branch 2 times, most recently from 1a0c427 to 09d7c2f Compare December 1, 2025 18:37
@elBoberido elBoberido marked this pull request as ready for review December 1, 2025 19:17
@elBoberido elBoberido requested a review from elfenpiff December 1, 2025 19:17
@elBoberido elBoberido marked this pull request as draft December 1, 2025 19:17
Base automatically changed from iox2-301-move-into-files-to-iox2-bb to main December 2, 2025 18:31
@elBoberido elBoberido dismissed elfenpiff’s stale review December 2, 2025 18:31

The base branch was changed.

@elBoberido elBoberido force-pushed the iox2-301-move-duration-files-to-iox2-bb branch from 09d7c2f to 83be8a5 Compare December 2, 2025 18:52
@elBoberido elBoberido marked this pull request as ready for review December 2, 2025 19:34
@elBoberido elBoberido changed the title [Stacked PR] [Based on #1206] [#301] Move 'Duration' files to 'iox2/bb' [#301] Move 'Duration' files to 'iox2/bb' Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 87.79343% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.37%. Comparing base (196c471) to head (77a3cc3).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2-bb/cxx/include/iox2/bb/duration.hpp 88.95% 13 Missing and 7 partials ⚠️
iceoryx2-cxx/src/config.cpp 80.00% 2 Missing ⚠️
iceoryx2-cxx/src/node.cpp 0.00% 2 Missing ⚠️
iceoryx2-cxx/include/iox2/listener.hpp 85.71% 0 Missing and 1 partial ⚠️
iceoryx2-cxx/src/waitset.cpp 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   78.42%   78.37%   -0.06%     
==========================================
  Files         411      410       -1     
  Lines       41006    40988      -18     
  Branches     1095     1093       -2     
==========================================
- Hits        32160    32124      -36     
- Misses       8013     8033      +20     
+ Partials      833      831       -2     
Flag Coverage Δ
CPP 72.69% <87.79%> (-0.11%) ⬇️
Rust 78.19% <83.01%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/cxx/include/iox2/bb/into.hpp 100.00% <ø> (ø)
iceoryx2-cxx/include/iox2/node.hpp 100.00% <ø> (ø)
...ceoryx2-cxx/include/iox2/service_builder_event.hpp 100.00% <ø> (ø)
iceoryx2-cxx/include/iox2/waitset.hpp 100.00% <ø> (ø)
iceoryx2-cxx/src/notifier.cpp 78.94% <100.00%> (-0.54%) ⬇️
iceoryx2-cxx/src/service_builder_event.cpp 74.03% <100.00%> (+0.45%) ⬆️
iceoryx2-cxx/src/static_config_event.cpp 66.66% <100.00%> (ø)
iceoryx2-cxx/include/iox2/listener.hpp 64.17% <85.71%> (-2.49%) ⬇️
iceoryx2-cxx/src/waitset.cpp 69.01% <80.00%> (-1.85%) ⬇️
iceoryx2-cxx/src/config.cpp 84.03% <80.00%> (+0.43%) ⬆️
... and 2 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

// this can then safely be converted to seconds as well as nanoseconds without loosing precision

// least common multiple of 2^32 and NANOSECONDS_PER_SECOND;
// for the following calculation it is not important to be the least common multiple, any common multiple will do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it that this part works... 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was quite confident when I wrote that code ... and we have test 😅

Maybe a mathematician can double check the formula @FerdinandSpitzschnueffler @elfenpiff

@elBoberido elBoberido requested a review from elfenpiff December 3, 2025 16:08
@elBoberido elBoberido merged commit cca0ed3 into main Dec 3, 2025
133 of 134 checks passed
@elBoberido elBoberido deleted the iox2-301-move-duration-files-to-iox2-bb branch December 3, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants