-
Notifications
You must be signed in to change notification settings - Fork 102
[#301] Move 'Duration' files to 'iox2/bb' #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54141ea to
4a82879
Compare
1a0c427 to
09d7c2f
Compare
… for stream operator
09d7c2f to
83be8a5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 78.42% 78.37% -0.06%
==========================================
Files 411 410 -1
Lines 41006 40988 -18
Branches 1095 1093 -2
==========================================
- Hits 32160 32124 -36
- Misses 8013 8033 +20
+ Partials 833 831 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| // this can then safely be converted to seconds as well as nanoseconds without loosing precision | ||
|
|
||
| // least common multiple of 2^32 and NANOSECONDS_PER_SECOND; | ||
| // for the following calculation it is not important to be the least common multiple, any common multiple will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take your word for it that this part works... 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was quite confident when I wrote that code ... and we have test 😅
Maybe a mathematician can double check the formula @FerdinandSpitzschnueffler @elfenpiff
Notes for Reviewer
This PR moves
iox2/legacy/duration.hppand its dependencies toiox2/bb/duration.hpp. Furthermore, the namespace is adjusted toiox2::bband the clang-tidy warnings are fixed.Pre-Review Checklist for the PR Author
Convert to draft)SPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)PR Reviewer Reminder
Post-review Checklist for the PR Author
References
Relates to #301