Skip to content

Conversation

@zmostafa
Copy link
Contributor

@zmostafa zmostafa commented Oct 27, 2025

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #957

@zmostafa zmostafa marked this pull request as draft October 27, 2025 14:25
@zmostafa zmostafa marked this pull request as ready for review October 27, 2025 14:33
@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch from 32c5fd7 to 777bd78 Compare October 27, 2025 15:11
@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch from 777bd78 to f404393 Compare October 27, 2025 15:15
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.92%. Comparing base (5636563) to head (5fa2f0b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   77.90%   77.92%   +0.02%     
==========================================
  Files         360      360              
  Lines       38788    38788              
  Branches      807      807              
==========================================
+ Hits        30217    30225       +8     
+ Misses       7932     7924       -8     
  Partials      639      639              
Flag Coverage Δ
CPP 65.91% <ø> (ø)
Rust 77.87% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch from a935791 to 6aba344 Compare October 27, 2025 17:27
@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch from 72009f0 to 129898c Compare October 27, 2025 19:00
@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch 2 times, most recently from 94f1b81 to 05b2cc8 Compare October 27, 2025 20:18
@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch from 79fa05f to 8993861 Compare October 27, 2025 20:21
@zmostafa zmostafa force-pushed the iox2-957-add-thread-sanitizers branch from 8993861 to c65e7c9 Compare October 27, 2025 20:26
set(ICEORYX2_TEST_CXX_FLAGS ${ICEORYX2_TEST_CXX_FLAGS} ${ICEORYX2_SANITIZER_FLAGS} CACHE INTERNAL "")

# Sanitizer flags must also be added to linker flags
set(ICEORYX2_LINK_FLAGS ${ICEORYX2_LINK_FLAGS} ${ICEORYX2_SANITIZER_FLAGS} CACHE INTERNAL "")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: this can be removed, after fixing the typo the linker already includes sanitizer flags

@zmostafa
Copy link
Contributor Author

@elBoberido would be nice to get your feedback about this PR and the test failure I am getting while running the tests with sanitizers, also I had issues with macos too. I tried to match sanitizers in iceoryx as much as I can and not sure what might be wrong or still missing.

@elfenpiff elfenpiff mentioned this pull request Nov 21, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add thread sanitizer

1 participant