Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.p2.publisher.eclipse #769

Merged

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

Copy link

github-actions bot commented Mar 22, 2025

Test Results

  375 files  ±0    375 suites  ±0   42m 5s ⏱️ -6s
1 905 tests ±0  1 902 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 715 runs  ±0  6 706 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit e526a34. ± Comparison against base commit 5e9376f.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/bundles/org.eclipse.equinox.p2.publisher.eclipse branch from 1862f11 to e526a34 Compare March 22, 2025 05:54
@laeubi laeubi merged commit 60ffcb8 into master Mar 23, 2025
12 checks passed
@akurtakov akurtakov deleted the clean-code/bundles/org.eclipse.equinox.p2.publisher.eclipse branch March 23, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants