Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Code for bundles/org.eclipse.equinox.p2.metadata #747

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Clean Code for bundles/org.eclipse.equinox.p2.metadata #747

merged 1 commit into from
Mar 22, 2025

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

Test Results

  375 files  +  125    375 suites  +125   43m 6s ⏱️ + 9m 59s
1 905 tests +    6  1 902 ✅ +    6  3 💤 ±0  0 ❌ ±0 
6 715 runs  +2 235  6 706 ✅ +2 232  9 💤 +3  0 ❌ ±0 

Results for commit e884e7b. ± Comparison against base commit 4cc4cc5.

♻️ This comment has been updated with latest results.

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.metadata branch 4 times, most recently from 8ec55fd to 9e511cb Compare March 21, 2025 02:56
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.p2.metadata branch from 9e511cb to e884e7b Compare March 22, 2025 02:52
laeubi
laeubi approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@laeubi laeubi merged commit 5e9376f into master Mar 22, 2025
12 checks passed
@laeubi laeubi deleted the clean-code/bundles/org.eclipse.equinox.p2.metadata branch March 22, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eclipse-equinox-bot @laeubi