-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP #1890 > support/v5.13] [core] Fixup build for Alpine #1895
Open
eclipse-ecal-bot
wants to merge
5
commits into
support/v5.13
Choose a base branch
from
cherry-pick/3b22b6e/support/v5.13
base: support/v5.13
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peguen
force-pushed
the
cherry-pick/3b22b6e/support/v5.13
branch
from
January 14, 2025 08:23
7686ab0
to
43896fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -17,8 +17,7 @@ | |||
* ========================= eCAL LICENSE ================================= | |||
*/ | |||
|
|||
#include <cstdlib> | |||
#include <cerrno> | |||
#include <errno.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead [modernize-deprecated-headers]
Suggested change
#include <errno.h> | |
#include <cerrno> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick failed
Cherry-picked PR #1890 to branch
support/v5.13
.The cherry-pick has failed.
The following files have caused conflicts:
Resolving
Please resolve conflicts manually. You can use this PR and branch to your convenience.
After resolving all conflicts, rebase-merge this PR.