[cmake] Create explicit warnings target (#1948)

* Add ecal warnings target; use keyword target_link_libraries
eclipse-ecal · Jan 27, 2025 · 8c2f54d · 8c2f54d
1 parent ce3d715
commit 8c2f54d
Show file tree

Hide file tree

Showing 75 changed files with 125 additions and 79 deletions.
diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml
@@ -194,6 +194,7 @@ jobs:
     # --------------------------------------------------------------------------------------------------
 
   sign-windows-installer:
+    if: github.repository == 'eclipse-ecal/ecal'
     runs-on: windows-2019
     needs: build-windows
 

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -495,6 +495,7 @@ install(FILES ${eCAL_config} ${eCAL_config_version}
 
 install(FILES
   cmake/helper_functions/ecal_add_functions.cmake
+  cmake/helper_functions/ecal_compiler_warnings.cmake
   cmake/helper_functions/ecal_helper_functions.cmake
   cmake/helper_functions/ecal_install_functions.cmake
   DESTINATION ${${PROJECT_NAME}_install_cmake_dir}/helper_functions

diff --git a/app/app_pb/CMakeLists.txt b/app/app_pb/CMakeLists.txt
@@ -68,7 +68,7 @@ target_compile_options(${PROJECT_NAME}
 
 set_property(TARGET ${PROJECT_NAME} PROPERTY POSITION_INDEPENDENT_CODE ON)
 
-target_link_libraries(${PROJECT_NAME} protobuf::libprotobuf)
+target_link_libraries(${PROJECT_NAME} PUBLIC protobuf::libprotobuf)
 target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_14) 
 
 ecal_install_library(${PROJECT_NAME})

diff --git a/app/meas_cutter/CMakeLists.txt b/app/meas_cutter/CMakeLists.txt
@@ -52,11 +52,13 @@ ecal_add_app_console(${PROJECT_NAME} ${meas_cutter_src})
 target_include_directories(${PROJECT_NAME}
   PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>)
 
-target_link_libraries(${PROJECT_NAME}   yaml-cpp::yaml-cpp
-                                        tclap::tclap
-                                        eCAL::ecal-utils
-                                        eCAL::hdf5
-                                        Threads::Threads)
+target_link_libraries(${PROJECT_NAME} PRIVATE
+  yaml-cpp::yaml-cpp
+  tclap::tclap
+  eCAL::ecal-utils
+  eCAL::hdf5
+  Threads::Threads
+)
 
 target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_14) 
 

diff --git a/app/mon/mon_cli/CMakeLists.txt b/app/mon/mon_cli/CMakeLists.txt
@@ -41,7 +41,7 @@ target_compile_definitions(${PROJECT_NAME}
 
 create_targets_protobuf()
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   tclap::tclap
   eCAL::protobuf_core
   eCAL::string_core

diff --git a/app/mon/mon_gui/CMakeLists.txt b/app/mon/mon_gui/CMakeLists.txt
@@ -195,7 +195,7 @@ ecal_add_app_qt(${PROJECT_NAME}
     ${autogen_ui}
 )
 
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
     protobuf::libprotobuf
     eCAL::core
     eCAL::core_pb
@@ -209,7 +209,7 @@ target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_14)
 
 if(ECAL_NPCAP_SUPPORT)
   add_definitions(-DECAL_NPCAP_SUPPORT)
-  target_link_libraries(${PROJECT_NAME}
+    target_link_libraries(${PROJECT_NAME} PRIVATE
     udpcap::udpcap
   )
 endif(ECAL_NPCAP_SUPPORT)

diff --git a/app/mon/mon_plugins/capnproto_reflection/CMakeLists.txt b/app/mon/mon_plugins/capnproto_reflection/CMakeLists.txt
@@ -58,7 +58,7 @@ ecal_add_mon_plugin(${PROJECT_NAME}
   METADATA src/metadata.json
 )
 
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
   Qt${QT_VERSION_MAJOR}::Core
   Qt${QT_VERSION_MAJOR}::Widgets
   eCAL::capnproto_core

diff --git a/app/mon/mon_plugins/plugin_template/CMakeLists.txt b/app/mon/mon_plugins/plugin_template/CMakeLists.txt
@@ -43,7 +43,7 @@ ecal_add_mon_plugin(${PROJECT_NAME}
   METADATA src/metadata.json
 )
 
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
   Qt${QT_VERSION_MAJOR}::Core
   Qt${QT_VERSION_MAJOR}::Widgets
   eCAL::core

diff --git a/app/mon/mon_plugins/protobuf_reflection/CMakeLists.txt b/app/mon/mon_plugins/protobuf_reflection/CMakeLists.txt
@@ -60,7 +60,7 @@ ecal_add_mon_plugin(${PROJECT_NAME}
 )
 
 create_targets_protobuf()
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
   Qt${QT_VERSION_MAJOR}::Core
   Qt${QT_VERSION_MAJOR}::Widgets
   eCAL::protobuf_core

diff --git a/app/mon/mon_plugins/raw_data_reflection/CMakeLists.txt b/app/mon/mon_plugins/raw_data_reflection/CMakeLists.txt
@@ -55,7 +55,7 @@ ecal_add_mon_plugin(${PROJECT_NAME}
 )
 
 create_targets_protobuf()
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
   Qt${QT_VERSION_MAJOR}::Core
   Qt${QT_VERSION_MAJOR}::Widgets
   eCAL::core

diff --git a/app/mon/mon_plugins/signals_plotting/CMakeLists.txt b/app/mon/mon_plugins/signals_plotting/CMakeLists.txt
@@ -72,7 +72,7 @@ ecal_add_mon_plugin(${PROJECT_NAME}
 
 create_targets_protobuf()
 
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
   Qt${QT_VERSION_MAJOR}::Core
   Qt${QT_VERSION_MAJOR}::Widgets
   eCAL::core

diff --git a/app/mon/mon_plugins/string_reflection/CMakeLists.txt b/app/mon/mon_plugins/string_reflection/CMakeLists.txt
@@ -55,7 +55,7 @@ ecal_add_mon_plugin(${PROJECT_NAME}
 )
 
 create_targets_protobuf()
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
   Qt${QT_VERSION_MAJOR}::Core
   Qt${QT_VERSION_MAJOR}::Widgets
   eCAL::string_core

diff --git a/app/mon/mon_tui/CMakeLists.txt b/app/mon/mon_tui/CMakeLists.txt
@@ -115,7 +115,7 @@ target_compile_definitions(${PROJECT_NAME}
 
 create_targets_protobuf()
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   protobuf::libprotobuf
   tclap::tclap
   eCAL::protobuf_core

diff --git a/app/play/play_cli/CMakeLists.txt b/app/play/play_cli/CMakeLists.txt
@@ -44,7 +44,7 @@ target_include_directories(${PROJECT_NAME} PRIVATE src)
 target_compile_definitions(${PROJECT_NAME}
   PRIVATE $<$<BOOL:${MSVC}>:PCRE_STATIC;_UNICODE>)
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
     termcolor::termcolor
     tclap::tclap
     eCAL::play_core

diff --git a/app/play/play_gui/CMakeLists.txt b/app/play/play_gui/CMakeLists.txt
@@ -139,7 +139,7 @@ ecal_add_app_qt(${PROJECT_NAME}
 )
 
 create_targets_protobuf()
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
     tclap::tclap
     CustomTclap
     eCAL::play_core

diff --git a/app/rec/rec_gui/CMakeLists.txt b/app/rec/rec_gui/CMakeLists.txt
@@ -170,7 +170,7 @@ ecal_add_app_qt(${PROJECT_NAME}
 )
 
 create_targets_protobuf()
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
     tclap::tclap
     protobuf::libprotobuf
     eCAL::core
@@ -195,7 +195,7 @@ if (WIN32 AND (${QT_VERSION_MAJOR} EQUAL 5))
     # Maybe we can re-enable the functionality with the following external lib:
     # https://github.com/oblivioncth/Qx
     #
-    target_link_libraries (${PROJECT_NAME}
+    target_link_libraries (${PROJECT_NAME} PRIVATE
         Qt${QT_VERSION_MAJOR}::WinExtras
     )
 endif()

diff --git a/app/rec/rec_server_cli/CMakeLists.txt b/app/rec/rec_server_cli/CMakeLists.txt
@@ -83,7 +83,7 @@ target_compile_definitions(${PROJECT_NAME}
 
 create_targets_protobuf()
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   tclap::tclap
   termcolor::termcolor
   eCAL::rec_server_core

diff --git a/app/sys/sys_cli/CMakeLists.txt b/app/sys/sys_cli/CMakeLists.txt
@@ -70,7 +70,7 @@ target_compile_definitions(${PROJECT_NAME}
 
 create_targets_protobuf()
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   tclap::tclap
   termcolor::termcolor
   eCAL::sys_core

diff --git a/app/sys/sys_client_cli/CMakeLists.txt b/app/sys/sys_client_cli/CMakeLists.txt
@@ -39,7 +39,7 @@ ecal_add_app_console(${PROJECT_NAME} ${source_files} ${win_src})
 
 create_targets_protobuf()
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   spdlog::spdlog
   tclap::tclap
   protobuf::libprotobuf

diff --git a/app/sys/sys_gui/CMakeLists.txt b/app/sys/sys_gui/CMakeLists.txt
@@ -174,7 +174,7 @@ ecal_add_app_qt(${PROJECT_NAME}
 
 create_targets_protobuf() 
 
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
     Qt${QT_VERSION_MAJOR}::Core
     Qt${QT_VERSION_MAJOR}::Widgets
     CustomQt

diff --git a/app/util/config/CMakeLists.txt b/app/util/config/CMakeLists.txt
@@ -30,7 +30,7 @@ target_include_directories(${PROJECT_NAME}
 target_compile_definitions(${PROJECT_NAME}
   PRIVATE $<$<BOOL:${MSVC}>:PCRE_STATIC;_UNICODE>)
 
-target_link_libraries(${PROJECT_NAME} eCAL::core)
+target_link_libraries(${PROJECT_NAME} PRIVATE eCAL::core)
 target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_14)
 
 ecal_install_app(${PROJECT_NAME})

diff --git a/app/util/launcher/CMakeLists.txt b/app/util/launcher/CMakeLists.txt
@@ -82,7 +82,7 @@ ecal_add_app_qt(${PROJECT_NAME}
     ${autogen_ui}
 )
 
-target_link_libraries (${PROJECT_NAME}
+target_link_libraries (${PROJECT_NAME} PRIVATE
     Qt${QT_VERSION_MAJOR}::Core
     Qt${QT_VERSION_MAJOR}::Widgets
     eCAL::apps

diff --git a/app/util/stop/CMakeLists.txt b/app/util/stop/CMakeLists.txt
@@ -30,7 +30,7 @@ target_include_directories(${PROJECT_NAME}
 target_compile_definitions(${PROJECT_NAME}
   PRIVATE $<$<BOOL:${MSVC}>:PCRE_STATIC;_UNICODE>)
 
-target_link_libraries(${PROJECT_NAME} eCAL::core)
+target_link_libraries(${PROJECT_NAME} PRIVATE eCAL::core)
 target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_14)
 
 ecal_install_app(${PROJECT_NAME})

diff --git a/cmake/helper_functions/ecal_add_functions.cmake b/cmake/helper_functions/ecal_add_functions.cmake
@@ -16,6 +16,10 @@
 #
 # ========================= eCAL LICENSE =================================
 
+include_guard(GLOBAL)
+
+include("${CMAKE_CURRENT_LIST_DIR}/ecal_compiler_warnings.cmake")
+
 # This function will set the output names of the target according to eCAL conventions.
 function(ecal_add_app_console TARGET_NAME)
   add_executable(${TARGET_NAME} ${ARGN})
@@ -24,6 +28,7 @@ function(ecal_add_app_console TARGET_NAME)
     VERSION ${eCAL_VERSION_STRING}
     SOVERSION ${eCAL_VERSION_MAJOR}
     OUTPUT_NAME ecal_${TARGET_NAME})
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 # This helper function automatically adds a gtest to ecal.
@@ -50,6 +55,7 @@ function(ecal_add_gtest TARGET_NAME)
     VERSION ${eCAL_VERSION_STRING}
     SOVERSION ${eCAL_VERSION_MAJOR}
     OUTPUT_NAME ecal_${TARGET_NAME})
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_app_gui TARGET_NAME)
@@ -59,6 +65,7 @@ function(ecal_add_app_gui TARGET_NAME)
     VERSION ${eCAL_VERSION_STRING}
     SOVERSION ${eCAL_VERSION_MAJOR}
     OUTPUT_NAME ecal_${TARGET_NAME})
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_app_qt TARGET_NAME)
@@ -70,6 +77,7 @@ function(ecal_add_app_qt TARGET_NAME)
   if(WIN32)
     set_target_properties(${PROJECT_NAME} PROPERTIES LINK_FLAGS "/SUBSYSTEM:WINDOWS /ENTRY:mainCRTStartup")
   endif()
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_mon_plugin TARGET_NAME)
@@ -94,7 +102,7 @@ function(ecal_add_mon_plugin TARGET_NAME)
       $<$<CONFIG:RelWithDebInfo>:QT_NO_DEBUG>
       $<$<CONFIG:MinSizeRel>:QT_NO_DEBUG>
   )
-    
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_rec_addon TARGET_NAME)
@@ -105,7 +113,7 @@ function(ecal_add_rec_addon TARGET_NAME)
     OUTPUT_NAME ecal_${TARGET_NAME}
     RUNTIME_OUTPUT_DIRECTORY $<IF:$<BOOL:${WIN32}>,${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/$<CONFIG>/ecalrec_addons,${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/ecal/addons/rec>
   )
-    
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_time_plugin TARGET_NAME)
@@ -114,6 +122,7 @@ function(ecal_add_time_plugin TARGET_NAME)
     VERSION ${eCAL_VERSION_STRING}
     SOVERSION ${eCAL_VERSION_MAJOR}
   )
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_shared_library TARGET_NAME)
@@ -122,6 +131,7 @@ function(ecal_add_shared_library TARGET_NAME)
     VERSION ${eCAL_VERSION_STRING}
     SOVERSION ${eCAL_VERSION_MAJOR}
     OUTPUT_NAME ecal_${TARGET_NAME})
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_static_library TARGET_NAME)
@@ -132,6 +142,7 @@ function(ecal_add_static_library TARGET_NAME)
     OUTPUT_NAME ecal_${TARGET_NAME}
     POSITION_INDEPENDENT_CODE ON
   )
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
 function(ecal_add_interface_library TARGET_NAME)
@@ -152,5 +163,6 @@ function(ecal_add_sample TARGET_NAME)
     VERSION ${eCAL_VERSION_STRING}
     SOVERSION ${eCAL_VERSION_MAJOR}
     OUTPUT_NAME ecal_sample_${TARGET_NAME})
+  ecal_add_compiler_warnings(${TARGET_NAME})
 endfunction()
 
diff --git a/cmake/helper_functions/ecal_compiler_warnings.cmake b/cmake/helper_functions/ecal_compiler_warnings.cmake
@@ -0,0 +1,27 @@
+include_guard(GLOBAL)
+
+add_library(_ecal_warnings INTERFACE)
+
+set(cxx_compiler_flags "")
+
+if("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
+  message(STATUS "MSVC detected - Adding flags")
+  set(cxx_compiler_flags "/MP" "/W4")
+elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU|Clang")
+  message(STATUS "Setting GNU/Clang flags")
+  set(cxx_compiler_flags "-Wall" "-Wextra")
+else()
+  message(WARNING "Unknown compiler, will not set warning flags")
+endif()
+
+target_compile_options(_ecal_warnings INTERFACE
+  "$<$<COMPILE_LANGUAGE:C,CXX>:${cxx_compiler_flags}>"
+)
+
+unset(cxx_compiler_flags)
+
+function(ecal_add_compiler_warnings TARGET_NAME)
+  target_link_libraries("${TARGET_NAME}" PRIVATE
+    "$<BUILD_INTERFACE:_ecal_warnings>"
+  )
+endfunction()
diff --git a/contrib/ecaltime/ecaltime_pb/CMakeLists.txt b/contrib/ecaltime/ecaltime_pb/CMakeLists.txt
@@ -57,7 +57,7 @@ target_compile_options(${PROJECT_NAME}
 
 set_property(TARGET ${PROJECT_NAME} PROPERTY POSITION_INDEPENDENT_CODE ON)
 
-target_link_libraries(${PROJECT_NAME} protobuf::libprotobuf)
+target_link_libraries(${PROJECT_NAME} PUBLIC protobuf::libprotobuf)
 target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_14)
 
 ecal_install_library(${PROJECT_NAME})

diff --git a/contrib/ecaltime/linuxptp/CMakeLists.txt b/contrib/ecaltime/linuxptp/CMakeLists.txt
@@ -38,7 +38,7 @@ endif()
 
 ecal_add_time_plugin(${PROJECT_NAME} SHARED ${ecal_time_linuxptp_src} ${ecal_time_linuxptp_header})
 
-target_link_libraries(${PROJECT_NAME} eCAL::core yaml-cpp::yaml-cpp)
+target_link_libraries(${PROJECT_NAME} PRIVATE eCAL::core yaml-cpp::yaml-cpp)
 
 target_include_directories(${PROJECT_NAME} 
   PRIVATE

diff --git a/contrib/ecaltime/localtime/CMakeLists.txt b/contrib/ecaltime/localtime/CMakeLists.txt
@@ -43,7 +43,7 @@ target_include_directories(${PROJECT_NAME}
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>)
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   Threads::Threads
   $<$<AND:$<BOOL:${UNIX}>,$<NOT:$<BOOL:${APPLE}>>,$<NOT:$<BOOL:${QNXNTO}>>>:rt>
   )

diff --git a/contrib/mma/CMakeLists.txt b/contrib/mma/CMakeLists.txt
@@ -80,7 +80,7 @@ target_include_directories(${PROJECT_NAME}
 
 create_targets_protobuf()
 
-target_link_libraries(${PROJECT_NAME}
+target_link_libraries(${PROJECT_NAME} PRIVATE
   Threads::Threads
   eCAL::protobuf_core
   eCAL::app_pb

diff --git a/ecal/core_pb/CMakeLists.txt b/ecal/core_pb/CMakeLists.txt
@@ -65,7 +65,7 @@ target_compile_options(${PROJECT_NAME}
 
 set_property(TARGET ${PROJECT_NAME} PROPERTY POSITION_INDEPENDENT_CODE ON)
 
-target_link_libraries(${PROJECT_NAME} protobuf::libprotobuf)
+target_link_libraries(${PROJECT_NAME} PUBLIC protobuf::libprotobuf)
 target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_14)
 
 ecal_install_library(${PROJECT_NAME})