Skip to content

Commit

Permalink
[cmake] Disable mon plugin and rec addon sdks by default unless build…
Browse files Browse the repository at this point in the history
…ing apps (#1920)

* Exclude more files from python sdist
* Correct required CMake version for wheel build
  • Loading branch information
DownerCase authored Jan 20, 2025
1 parent 43dcb74 commit 3465472
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
11 changes: 7 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ option(HAS_MESSAGEPACK "Platform supports messagepack li

option(BUILD_DOCS "Build the eCAL documentation" OFF)
option(BUILD_APPS "Build the eCAL applications" ON)
option(BUILD_APP_REC_ADDON_SDK "Build eCAL rec addon SDK" ${BUILD_APPS})
option(BUILD_SAMPLES "Build the eCAL samples" ON)
option(BUILD_TIME "Build the eCAL time interfaces" ON)
option(BUILD_PY_BINDING "Build eCAL python binding" OFF)
Expand Down Expand Up @@ -283,15 +284,17 @@ endif()
# --------------------------------------------------------
# ecal mon plugin sdk
# --------------------------------------------------------
if(HAS_QT)
if(HAS_QT AND BUILD_APPS)
add_subdirectory(app/mon/mon_plugin_lib)
endif()

# --------------------------------------------------------
# ecal rec addon sdk
# --------------------------------------------------------
add_subdirectory(app/rec/rec_addon_core)
add_subdirectory(app/rec/rec_addon_dummy)
if(BUILD_APP_REC_ADDON_SDK)
add_subdirectory(app/rec/rec_addon_core)
add_subdirectory(app/rec/rec_addon_dummy)
endif()

# --------------------------------------------------------
# ecal time
Expand Down Expand Up @@ -335,8 +338,8 @@ add_subdirectory(lang/c)
# --------------------------------------------------------
# console applications
# --------------------------------------------------------
add_subdirectory(app/apps)
if(BUILD_APPS)
add_subdirectory(app/apps)
if (HAS_FTXUI)
add_subdirectory(app/mon/mon_tui)
endif()
Expand Down
11 changes: 4 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ sdist.only-include = [
"/NOTICE.txt",
"/README.md",
"/app/app_pb/",
"/app/apps/", # TODO: Remove this directory
"/app/rec/rec_addon_core/", # TODO: Remove this directory
"/app/rec/rec_addon_dummy/", # TODO: Remove this directory
"/cmake/",
"/contrib/",
"/cpack/",
Expand All @@ -55,11 +52,11 @@ sdist.only-include = [
"lang/c/",
"lang/python/",

"serialization/protobuf",
"serialization/string",
"serialization/protobuf",
"serialization/string",

"thirdparty/cmakefunctions/",
"thirdparty/ecaludp/",
"thirdparty/ecaludp/",
"thirdparty/protobuf/",
"thirdparty/recycle/",
"thirdparty/tclap/",
Expand All @@ -82,7 +79,7 @@ sdist.only-include = [

[tool.scikit-build]
# Will be installed from PyPI if system version is too old/missing
cmake.version = ">=3.18"
cmake.version = ">=3.24" # For SET_DEPENDENCY_PROVIDER
build.targets = ["ecal_python"] # Targets to build
build-dir = "./_python_build" # Build directory for unisolated builds
install.components = ["python"] # CMake component to install
Expand Down

0 comments on commit 3465472

Please sign in to comment.