Skip to content

chore: publish version 2025-1-RC1 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arnoweiss
Copy link
Contributor

What this PR changes/adds

This PR publishes a separate github page for the current state of the spec as a first Release Candidate for version 2025-1.

Why it does that

Lots of new features.

Further notes

There is further action required from the committer who merges this PR.
Github does not allow to merge tags via PRs. Every committer however can push tags to main. After merging this PR, a committer must:

  1. create a tag called 2025-1-RC1 on commit d8f6428a1b7a9a9be13719c226eaa8d9cbb5adc9 and push if done in IDE.
  2. rerun all github actions.

This will lead to a setup like in my fork:
https://arnoweiss.github.io/DataspaceProtocol/
https://arnoweiss.github.io/DataspaceProtocol/2025-1-RC1/
https://arnoweiss.github.io/DataspaceProtocol/HEAD/

@arnoweiss arnoweiss requested a review from a team February 27, 2025 14:37
Copy link
Contributor

@mkollenstart mkollenstart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't commit d8f6428 be invalid if we squash and merge?
So shouldn't we merge this one with the "RC1" in the titles in index.html, then create a tag, and after that create a new pull request updating the index.html?

Copy link
Contributor

@ssteinbuss ssteinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssteinbuss
Copy link
Contributor

Won't commit d8f6428 be invalid if we squash and merge? So shouldn't we merge this one with the "RC1" in the titles in index.html, then create a tag, and after that create a new pull request updating the index.html?

We plan rebase and merge

@ssteinbuss ssteinbuss merged commit 9bac6a0 into eclipse-dataspace-protocol-base:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants