Changing ECA signature #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
trittsv
reviewed
Apr 23, 2024
There was a problem hiding this comment.
@RamziKaroui the macos .DS_Store files should not be checked into git, may you can remove this file?
trittsv
reviewed
Apr 23, 2024
| find_package(Idlpp-cxx REQUIRED) | ||
| find_package(CycloneDDS REQUIRED) | ||
|
|
||
| if (NOT TARGET CycloneDDS_CXX_API::ddscxx) |
There was a problem hiding this comment.
@RamziKaroui may you can update the cmake file, the target is not called ..._API anymore. May you can update the code with the current master?
trittsv
reviewed
Apr 23, 2024
| #include <iostream> | ||
| #include "dds/dds.hpp" | ||
| #include "dds/core/ddscore.hpp" | ||
| #include "ATCDataModel_DCPS.hpp" |
There was a problem hiding this comment.
@RamziKaroui may you can update the source code too for the current master. There is no _DCPS anymore.
And no need to include dds/core/ddscore, its already included in dds/dds.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: [email protected] [email protected]