Fix null test and write test issues about the stat parameter

This issue may cause SegFault if pass null to state, and miss the validation by test_user_memory(...) if not null.
eckelj · Feb 27, 2019 · 5d799d2 · 5d799d2
1 parent aed520f
commit 5d799d2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/LibOS/shim/src/sys/shim_stat.c b/LibOS/shim/src/sys/shim_stat.c
@@ -39,7 +39,7 @@ int shim_do_stat (const char * file, struct stat * stat)
     if (!file || test_user_string(file))
         return -EFAULT;
 
-    if (!stat && test_user_memory(stat, sizeof(*stat), true))
+    if (!stat || test_user_memory(stat, sizeof(*stat), true))
         return -EFAULT;
 
     int ret;
@@ -67,7 +67,7 @@ int shim_do_lstat (const char * file, struct stat * stat)
     if (!file || test_user_string(file))
         return -EFAULT;
 
-    if (!stat && test_user_memory(stat, sizeof(*stat), true))
+    if (!stat || test_user_memory(stat, sizeof(*stat), true))
         return -EFAULT;
 
     int ret;