Implement Promise then() logic for pending state and Promise.all/race methods#27
Draft
Implement Promise then() logic for pending state and Promise.all/race methods#27
Conversation
Author
|
@echosoar 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…e (partial) Co-authored-by: echosoar <14832743+echosoar@users.noreply.github.com>
Co-authored-by: echosoar <14832743+echosoar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 实现 Promise 的 then 逻辑
Implement Promise then() logic for pending state and Promise.all/race methods
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the missing Promise functionality as requested in the issue:
🔧 Promise.then() for Pending Promises
Previously, when calling
.then()on a promise in pending state, the callback was ignored and the method returnedundefined. Now promises properly queue callbacks and execute them when resolved/rejected:🔧 Promise.all() Implementation
Added
Promise.all()static method that waits for all input promises to resolve, or rejects immediately if any promise rejects:🔧 Promise.race() Implementation
Added
Promise.race()static method that resolves/rejects as soon as the first input promise settles:🔧 Proper Promise Resolution Logic
Enhanced the promise resolution to correctly handle when promises are returned from
.then()handlers, following ECMAScript specifications:📋 Changes Made
[[PromiseFulfillReactions]]and[[PromiseRejectReactions]]) to promise objectsthen()method to queue callbacks for pending promises and return new promisesresolve()andreject()functions to execute stored callback reactionsPromise.all()andPromise.race()static methods with full ECMAScript complianceAll existing promise tests continue to pass, ensuring no regression in functionality.
Fixes #26.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.