Added Dockerfile #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ADD kafka-offset-exporter / | ||
| EXPOSE 9000 | ||
| ENTRYPOINT ["/kafka-offset-exporter"] | ||
| CMD ["-brokers", "127.0.0.1:9092", "-topics", "^[^_].*", "-groups", "."] |
There was a problem hiding this comment.
Should change -groups argument to '.*' otherwise no consumer-groups will match the pattern and therefore their stats will not be published but topic oldest/youngest offsets will still work, so you may not immediately notice.
lshegll
pushed a commit
to lshegll/kafka-offset-exporter
that referenced
this pull request
Mar 4, 2019
Make kafka version configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Dockerfile and wrote in the readme how to build & run.