Potential fix for code scanning alert no. 7126: Multiplication result converted to larger type #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI(CodeQL): Scan C/C++ with build-mode: none
… converted to larger type Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| for (t = start; t != stop; t += direction) { | ||
| tmpvt[t][0] = (vertices[t << 1] + xloc) * D_spec->xscale; | ||
| tmpvt[t][1] = (D_Cap->z) * D_spec->yscale; | ||
| tmpvt[t][1] = ((double) D_Cap->z) * D_spec->yscale; |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| tmpvt[t][1] = ((double) D_Cap->z) * D_spec->yscale; | |
| tmpvt[t][1] = ((double)D_Cap->z) * D_spec->yscale; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/echoix/grass/security/code-scanning/7126
To address the risk of overflow, make sure the multiplication happens in double-precision, not a smaller data type. The most reliable fix is to cast either
D_Cap->zorD_spec->yscaleto double before performing the multiplication. This ensures the multiplication itself is evaluated in double-precision and no intermediate overflow can occur in smaller types. The required change is on line 69 in raster3d/r3.showdspf/draw_cappolys_ogl.c:Change
to
No imports or additional definitions are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.