Skip to content

fix(frontend): fixes dayjs locales #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

fix(frontend): fixes dayjs locales #7639

wants to merge 1 commit into from

Conversation

usu
Copy link
Member

@usu usu commented Jun 24, 2025

Fixes #7631

  • Fix wrong M/D date format
  • Fix logic to map our own i18n locales to available dayjs locales
    • always use en-gb for English, which by default uses 24h time format
    • use de-ch as fallback for rm-*

@usu usu added the deploy! Creates a feature branch deployment for this PR label Jun 24, 2025
@usu usu temporarily deployed to feature-branch June 24, 2025 20:00 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2025 •
edited
Loading

✅ Feature branch deployment ready!

Name Link
😎 Deployment https://pr7639.ecamp3.ch/
🔑 Login [email protected] / test
🕒 Last deployed at Tue Jun 24 2025 22:02:32 GMT+0200
🔨 Latest commit afdd198fb477f27f06718ed82b16aa349e973622
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/15860192908/job/44715529491
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

@usu usu requested a review from a team June 24, 2025 20:01
@manuelmeister manuelmeister requested a review from a team June 24, 2025 20:06
carlobeltrame
carlobeltrame reviewed Jun 24, 2025
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, consider moving the fourfold duplicated logic to common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlobeltrame carlobeltrame carlobeltrame left review comments

@BacLuc BacLuc BacLuc approved these changes

@manuelmeister manuelmeister manuelmeister approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time formatting problem
4 participants
@usu @BacLuc @manuelmeister @carlobeltrame