Skip to content

Feature/activity load selected checklist items as collection #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 24, 2025
Merged

Feature/activity load selected checklist items as collection #7199

merged 6 commits into from
Jun 24, 2025

Conversation

pmattmann
Copy link
Member

ContentNode/ChecklistNodes: ChecklistItems-Collection-Link
Collection-Link allows to load all selected ChecklistItems in one Request

@pmattmann pmattmann requested a review from a team April 12, 2025 10:01
@pmattmann pmattmann requested a review from a team April 12, 2025 10:09
BacLuc
BacLuc reviewed Apr 12, 2025
View reviewed changes
@simfeld simfeld added the deploy! Creates a feature branch deployment for this PR label Apr 12, 2025
@simfeld simfeld temporarily deployed to feature-branch April 12, 2025 10:32 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2025 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

BacLuc
BacLuc previously requested changes Apr 12, 2025
View reviewed changes
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is silly behavior with the checklist overview

@BacLuc
Copy link
Contributor

BacLuc commented Apr 13, 2025 •
edited
Loading

Maybe part of your problem is solved with 82ac728
in

@pmattmann pmattmann force-pushed the feature/activity-load-selected-checklist-items-as-collection branch from 6c9cdbb to e6e4083 Compare May 7, 2025 17:48
@pmattmann pmattmann temporarily deployed to feature-branch May 7, 2025 17:52 — with GitHub Actions Inactive
@pmattmann pmattmann temporarily deployed to feature-branch May 10, 2025 11:19 — with GitHub Actions Inactive
@pmattmann pmattmann temporarily deployed to feature-branch May 10, 2025 12:19 — with GitHub Actions Inactive
@pmattmann pmattmann temporarily deployed to feature-branch May 10, 2025 12:35 — with GitHub Actions Inactive
@BacLuc BacLuc dismissed their stale review May 11, 2025 01:51

I am on vacation and don't want to block this.

@pmattmann pmattmann temporarily deployed to feature-branch May 11, 2025 16:39 — with GitHub Actions Inactive
@pmattmann pmattmann force-pushed the feature/activity-load-selected-checklist-items-as-collection branch from 94b0287 to 0fd0649 Compare May 11, 2025 16:46
@pmattmann pmattmann temporarily deployed to feature-branch May 11, 2025 16:51 — with GitHub Actions Inactive
@pmattmann
Copy link
Member Author

finally...

now both cases work:

  • navigation within the camp to the checklist generates only a few WebRequests
  • reload of a checklist generates only a few WebRequests

@pmattmann pmattmann requested review from a team and carlobeltrame May 11, 2025 16:53
@pmattmann pmattmann temporarily deployed to feature-branch May 11, 2025 16:59 — with GitHub Actions Inactive
carlobeltrame
carlobeltrame reviewed May 11, 2025
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On camp admin -> checklists, we still have n+1 requests (both when navigating there or reloading the page there). Is this a topic for another PR?

@BacLuc
Copy link
Contributor

BacLuc commented Jun 22, 2025

any updates here?

pmattmann added 2 commits June 24, 2025 20:32
@pmattmann
add search-filter for checklistNodes
d8fb3e7 
load checklist_items, checklist_nodes, root-content_nodes
each in one request
@pmattmann
remove console.log
6085841
@pmattmann pmattmann force-pushed the feature/activity-load-selected-checklist-items-as-collection branch from f612e13 to 6085841 Compare June 24, 2025 18:33
@pmattmann pmattmann requested review from carlobeltrame, usu and a team June 24, 2025 19:45
carlobeltrame
carlobeltrame approved these changes Jun 24, 2025
View reviewed changes
@pmattmann pmattmann added this pull request to the merge queue Jun 24, 2025
Merged via the queue into ecamp:devel with commit 7deddd0 Jun 24, 2025
30 checks passed
@pmattmann pmattmann deleted the feature/activity-load-selected-checklist-items-as-collection branch June 24, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BacLuc BacLuc BacLuc left review comments

@manuelmeister manuelmeister manuelmeister approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

@usu usu Awaiting requested review from usu

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmattmann @BacLuc @usu @manuelmeister @carlobeltrame @simfeld