cmake: make installed package relocatable #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the absolute include header path from the install target. The
created CMake package still has the right include generated:
```cmake
set_target_properties(libdeflate::libdeflate_static PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
)
```
As mentioned in the
[Creating Relocatable Packages](https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-relocatable-packages)
section of the CMake documentation packages created with
`install(EXPORT)` are designed to be relocatable.
This also makes it possible to cache the install directory over multiple
computer (for example through a package manager).
NeroBurner
force-pushed
the
cmake_install_relocatable
branch
from
c31404e to
75c0ad6
Compare
Contributor
Author
|
fixed the markdown link in the commit message (sorry for the noise, I found the oopsie only after creating the PR 😅 ) |
NeroBurner
added a commit
to cpp-pm/hunter
that referenced
this pull request
Sep 15, 2025
Need to use a patched version of `libdeflate` as the created CMake config contains absolute paths breaking the caching. Once ebiggers/libdeflate#434 is merged and released we can use pure upstream. Fixes: #804
NeroBurner
added a commit
to cpp-pm/hunter
that referenced
this pull request
Sep 15, 2025
Need to use a patched version of `libdeflate` as the created CMake config contains absolute paths breaking the caching. Once ebiggers/libdeflate#434 is merged and released we can use pure upstream. Fixes: #804
NeroBurner
added a commit
to cpp-pm/hunter
that referenced
this pull request
Sep 15, 2025
Need to use a patched version of `libdeflate` as the created CMake config contains absolute paths breaking the caching. Once ebiggers/libdeflate#434 is merged and released we can use pure upstream. Fixes: #804
Owner
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the absolute include header path from the install target. The created CMake package still has the right include generated:
As mentioned in the
Creating Relocatable Packages section of the CMake documentation packages created with
install(EXPORT)are designed to be relocatable.This also makes it possible to cache the install directory over multiple computer (for example through a package manager).