Avoid TypeError: must be str, not bytes when the request fails #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been seeing the following (non reproducible) error message from time to time with the fasta.py script:
The
restRequest
function returns astr
when the request succeeds. When the request fails, an additional call torequests.get(url)
is performed, and the raw response.content
is returned asbytes
instead, without conversion.This PR converts the content to a
str
also in case of failure.PS: not sure if returning the error contents is the right thing to do in this context, but that's an other story.