Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Usability improvements #1

wants to merge 1 commit into from

Conversation

asafh
Copy link

@asafh asafh commented Jan 5, 2020

Hi @eberkund,
I've made some usability improvements for this tool. I hope you find them useful as well. The changes:

  1. Accepting the input files as parameters (with defaults where makes sense): keyfile, template, users csv
  2. Allowing arbitrary fields in the template (and csv) by parsing it as a dictionary
  3. Parsing the template file once and reusing it for all rendering
  4. Allowing to generate signature html files as well (if some of your users use Outlook for instance)
  5. (to be used together with 4) allowing to disable API calls (e.g. only want to check how the template is rendered for your users)

Cheers and thanks for sharing.

…gs. Optionally output signatures to files. Optionally disable API calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant