Editor and Canvas communication with postMessage #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maarten2424 is attempting to deploy a commit to the Shopstory Team on Vercel. A member of the Team first needs to authorize it. |
maarten2424
force-pushed
the
feat/remove-editor-context-canvas
branch
5 times, most recently
from
3c8dd71 to
faa8b7f
Compare
maarten2424
force-pushed
the
feat/remove-editor-context-canvas
branch
from
faa8b7f to
d708b88
Compare
r00dY
requested changes
May 7, 2024
| meta: CompilationMetadata | null; | ||
| compiled: CompiledShopstoryComponentConfig | null; | ||
| externalData: FetchOutputResources | null; | ||
| formValues: EditorContextType["form"]["values"] | null; |
There was a problem hiding this comment.
Can we name it entry? It's the naming we're using right now.
r00dY
reviewed
May 8, 2024
| }, | ||
| }; | ||
|
|
||
| function useCanvasGlobalKeyboardShortcuts() { |
There was a problem hiding this comment.
There's quite a lot of duplication between this function and old useEditorGlobalKeyboardShortcuts. We should unify them a bit, otherwise it's gonna be hard to keep that stable later.
r00dY
reviewed
May 8, 2024
r00dY
reviewed
May 8, 2024
r00dY
reviewed
May 8, 2024
maarten2424
force-pushed
the
feat/remove-editor-context-canvas
branch
from
c515c38 to
4a37ec9
Compare
maarten2424
force-pushed
the
feat/remove-editor-context-canvas
branch
from
7a9bc0b to
170935a
Compare
r00dY
changed the title
…hq/easyblocks into feat/remove-editor-context-canvas
r00dY
reviewed
Jun 5, 2024
packages/core/src/compiler/builtins/$richText/utils/getRichTextComponentConfigFragment.ts
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feat: send toggle-settings event for closable component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes editor context from Canvas element
Rewrite
window.parentlogic towindow.postmessageon aCanvasProviderThis way the canvas can be hosted externally and it won't run into any CORS issues