Fix incorrect requires in scanner policy manifests#64
Conversation
Claude Auto-Approve ReviewSummary: This PR corrects the Scope: ISOLATED
Conclusion: ✅ Auto-approved (isolated changes, no issues) |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughUpdated landing_page.requires in four policy files to replace Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
I feel like keeping these up to date is going to be a difficult chore |
4f35549 to
834fce0
Compare
All four scanner policies (container-scan, sca, sast, iac-scan) incorrectly listed the github collector as a dependency. Updated to reference the actual collectors that write to each policy's Component JSON paths: - container-scan: dockerfile (applicability gate) + snyk (container scan data) - sca: snyk + semgrep (both write .sca) - sast: semgrep + snyk (both write .sast) - iac-scan: snyk (writes .iac_scan)
834fce0 to
9942f5c
Compare
All four scanner policies (container-scan, sca, sast, iac-scan) incorrectly listed the
githubcollector as a dependency in theirlanding_page.requiresfield. None of these policies actually depend on the github collector.Changes
Updated
requiresto reference the actual collectors that write to each policy's Component JSON paths:Why
.container_scanis written by the snyk collector (snyk container), not github.scais written by snyk and semgrep collectors.sastis written by semgrep and snyk collectors.iac_scanis written by the snyk collector (snyk iac), not github.containers(applicability gate for container-scan) is written by the dockerfile collectorThis fix was generated by AI.
Summary by CodeRabbit