Update hardcoded I2S::SYSCLK exact mappings - #3497
Merged
Merged
Conversation
Adds a utility to run on the Pico and Pico2 to identify the lowest frequency error possible for a given output sample rate. Use that data on the Pico and Pico2 to implement a smarter I2S::setSysClk() method which varies the SYSCLK depending on the sample rate and if the I2S is bidirectional. Originally had the same hardcoded values for RP2040 and RP2350, and the RP2040 values were calculated from the release max F_CPU of 133, not the new official 200MHz support. Fixes #3496
Owner
Author
|
For posterity, the output of the brute force checker on real HW as of today is RP2040RP2350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a utility to run on the Pico and Pico2 to identify the lowest frequency error possible for a given output sample rate.
Use that data on the Pico and Pico2 to implement a smarter I2S::setSysClk() method which varies the SYSCLK depending on the sample rate and if the I2S is bidirectional.
Originally had the same hardcoded values for RP2040 and RP2350, and the RP2040 values were calculated from the release max F_CPU of 133, not the new official 200MHz support.
Fixes #3496