[6.x.x] Adds in memory cache for RPC query results #5191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinhapa
force-pushed
the
in-memory-rpcfiles-6.x.x
branch
2 times, most recently
from
8388d1b to
760469d
Compare
|
Uhh, I need to see what this does for xst |
|
@reinhapa should this be forward ported to existdb 7 or is it already in place there? |
Review is already happening at the source for eXist-db 7.x.x - #5188 |
dizzzz
approved these changes
Jan 29, 2024
reinhapa
force-pushed
the
in-memory-rpcfiles-6.x.x
branch
from
ef78b22 to
9971e76
Compare
- Use in memory caching for resuls smaller 4 MB adding new CachedContentFile and companion test case - Extended XmlRpcTest to improve coverage of RpcConnection - Added new QueryResultCacheTest Signed-off-by: Patrick Reinhart <[email protected]>
reinhapa
force-pushed
the
in-memory-rpcfiles-6.x.x
branch
from
9971e76 to
d89b881
Compare
Replaces direct construction of in memory RPC results with pooled instances. Signed-off-by: Patrick Reinhart <[email protected]>
reinhapa
force-pushed
the
in-memory-rpcfiles-6.x.x
branch
from
31a21b5 to
f1d6e02
Compare
|
@adamretter PR is ready for review 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5188.
Enables in-memory query result values less than 4 MB instead of writing them to a temporary file.
By using the in-memory-buffer no potential virus scanner is trigger either on the server as on the client side. This almost doubled the performance on our productive systems, when using this change.