[24066] Refactor Discovery Server to update client behavior

[raulojeda22]

Description

Before, in the Discovery Server there was a distinction between CLIENT and SUPER_CLIENT participants.

In this PR the behavior of these has been unified, now both CLIENT and SUPER_CLIENT act as a SUPER_CLIENT.

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• Any new/modified methods have been properly documented using Doxygen.
• N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• New feature has been added to the versions.md file (if applicable).
• New feature has been documented/Current behavior is correctly described in the documentation.
  • Related documentation PR: [24066] Update discovery server client pro feature Fast-DDS-docs#1191
• N/A Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for b78feb7.

❌ Job Failures

Pipeline	Job	Health on master	Retries	🔍 CI Insights	📄 Logs
Fast DDS MacOS CI	mac-ci / fastdds_test ()		0	View	View
Fast DDS Sanitizers CI	sanitizers-ci / asan_discovery_server_test		0	View	View
	sanitizers-ci / asan_fastdds_test		0	View	View
Fast DDS Ubuntu CI	ubuntu-ci / fastdds_discovery_server_test (RelWithDebInfo)		0	View	View
	ubuntu-ci / fastdds_test (RelWithDebInfo)		0	View	View
Fast DDS Windows CI	windows-ci / fastdds_test (RelWithDebInfo, blackbox), v142		0	View	View
	windows-ci / fastdds_test (RelWithDebInfo, blackbox), v143		0	View	View

✅ Passed Jobs With Interesting Signals

Pipeline	Job	Signal	Health on master	Retries	🔍 CI Insights	📄 Logs
Fast DDS Ubuntu CI	ubuntu-ci / fastdds_build (RelWithDebInfo)	Base branch is broken, but the job passed. Looks like this might be a real fix 💪		0	View	View

[MiguelCompany]

In general, I think we are looking for a more profound change: for all discovered clients, we create a DiscoveryParticipantChangeData with is_client_ = false and is_superclient_ = true.

Even better, we could remove is_client altogether.

[raulojeda22]

In general, I think we are looking for a more profound change: for all discovered clients, we create a DiscoveryParticipantChangeData with is_client_ = false and is_superclient_ = true.

Even better, we could remove is_client altogether.

First easier changed pushed, now working on removing is_client altogether

[MiguelCompany]

Apart from the comments below, we should change PDP::set_external_participant_properties_() so it serializes SUPER_CLIENT when discoveryProtocol equals CLIENT

[MiguelCompany]

LGTM with green CI