forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution] [Attack discovery] Adds missing aria-label for th…
…e information button icon (elastic#206886) ### [Security Solution] [Attack discovery] Adds missing aria-label for the information button icon This PR fixes an a11y issue reported in <elastic#206353>, where the information button icon, displayed while Attack discoveries are generated, was missing an `aria-label`. This PR also updates an i18n translation in the same file, to add a missing word. The _Before_ and _After_ screenshots below illustrate the fix, desk tested with Axe: **Before** ![before](https://github.com/user-attachments/assets/a75d8b0c-2af7-44d0-9b10-fb961c5bd60e) _Above: Before the fix, 1 Axe issue was detected while discoveries are generated_ **After** ![after](https://github.com/user-attachments/assets/5419f278-6963-47e2-bc99-35d5e6c2e64e) _Above: After the fix, 0 Axe issues are detected while discoveries are generated_ #### Desk testing The fix for this PR was desk tested locally via Axe. Reproduction steps: <elastic#206353>
- Loading branch information
1 parent
aaf7b9e
commit 93d1134
Showing
3 changed files
with
26 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters