-
Notifications
You must be signed in to change notification settings - Fork 672
feat: set default user and workdir when using Dockerfile #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 934dc3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1f8171b
to
73cd236
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will check the tests, meanwhile change the relative import .template to absolute e2b.template
there is a bug, we'll fix it in future PR
The relative .template is in fixtures. That should be correct there. Commented out the fromDockerfile/from_dockerfile stacktraces tests for now as they're broken. We'll fix it in a future PR. |
Set default user for Dockerfiles. Includes also small migrate fixes.
Note
Defaults Dockerfile-based templates to user 'user' and workdir '/home/user', updates CLI templates (sudo start/ready, relative Python import), and allows template migration without a config file.
packages/js-sdk/src/template/dockerfileParser.ts
) and Python (packages/python-sdk/e2b/template/dockerfile_parser.py
): after parsing, set defaultssetUser('user')
andsetWorkdir('/home/user')
.from .template import template
.sudo
; removed explicit root/workdir before start/ready.e2b.toml
; uses default config values and prints a warning instead of exiting.set_user('user')
,set_workdir('/home/user')
,sudo
start/ready, relative imports).fromDockerfile
in JS/Python until fixed.@e2b/cli
,@e2b/python-sdk
, ande2b
.Written by Cursor Bugbot for commit 934dc3b. This will update automatically on new commits. Configure here.