Skip to content

support overriding apiUrl directly #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+20 −3
Open

support overriding apiUrl directly #948

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3e20d4a
support overriding api_url directly
djeebus Oct 13, 2025
f2f3bf9
maybe this?
djeebus Oct 13, 2025
090fd29
try once more
djeebus Oct 13, 2025
474d0bb
Add a changeset
djeebus Oct 14, 2025
f2540b5
use similar patterns as other fields
djeebus Oct 14, 2025
d8bb0cb
format it
djeebus Oct 14, 2025
f351e68
revert tool versions
djeebus Oct 14, 2025
60a80a1
Merge branch 'main' into support-overriding-api-url-ts
djeebus Oct 14, 2025
2cb6e6d
Merge branch 'main' into support-overriding-api-url-ts
djeebus Oct 15, 2025
9c0e87b
remove unnecessary override
djeebus Oct 15, 2025
4e2a9b4
Merge remote-tracking branch 'origin/main' into support-overriding-ap…
djeebus Oct 16, 2025
1d529eb
Merge branch 'main' into support-overriding-api-url-ts
djeebus Oct 16, 2025
14387da
can't null coallesce an empty string
djeebus Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/cli/.tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
nodejs 20
pnpm 9
1 change: 1 addition & 0 deletions packages/cli/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,6 @@ const userConfig = getUserConfig()
export const connectionConfig = new e2b.ConnectionConfig({
accessToken: process.env.E2B_ACCESS_TOKEN || userConfig?.accessToken,
apiKey: process.env.E2B_API_KEY || userConfig?.teamApiKey,
apiUrl: process.env.E2B_API_URL,
})
export const client = new e2b.ApiClient(connectionConfig)
10 changes: 7 additions & 3 deletions packages/js-sdk/src/connectionConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ export interface ConnectionOpts {
* @default E2B_DOMAIN // environment variable or `e2b.app`
*/
domain?: string
/**
* API Url to use for the API.
*/
apiUrl?: string
/**
* If true the SDK starts in the debug mode and connects to the local envd API server.
* @internal
Expand Down Expand Up @@ -78,9 +82,9 @@ export class ConnectionConfig {
this.headers = opts?.headers || {}
this.headers['User-Agent'] = `e2b-js-sdk/${version}`

this.apiUrl = this.debug
? 'http://localhost:3000'
: `https://api.${this.domain}`
this.apiUrl = opts?.apiUrl ?? (
this.debug ? 'http://localhost:3000' : `https://api.${this.domain}`
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API URL Config Inconsistency

The apiUrl option's fallback logic is inconsistent with other config options. It doesn't read the E2B_API_URL environment variable by default, and the ?? operator doesn't treat empty strings as invalid, which can cause network requests to fail.

Fix in Cursor Fix in Web

}

private static get domain() {
Expand Down
Loading