-
Notifications
You must be signed in to change notification settings - Fork 668
support overriding apiUrl directly #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djeebus
wants to merge
10
commits into
main
Choose a base branch
from
support-overriding-api-url-ts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−3
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3e20d4a
support overriding api_url directly
djeebus f2f3bf9
maybe this?
djeebus 090fd29
try once more
djeebus 474d0bb
Add a changeset
djeebus f2540b5
use similar patterns as other fields
djeebus d8bb0cb
format it
djeebus f351e68
revert tool versions
djeebus 60a80a1
Merge branch 'main' into support-overriding-api-url-ts
djeebus 2cb6e6d
Merge branch 'main' into support-overriding-api-url-ts
djeebus 9c0e87b
remove unnecessary override
djeebus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'e2b': patch | ||
'@e2b/cli': patch | ||
--- | ||
|
||
Support overriding apiUrl via E2B_API_URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
nodejs 20 | ||
pnpm 9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,10 @@ export interface ConnectionOpts { | |
* @default E2B_DOMAIN // environment variable or `e2b.app` | ||
*/ | ||
domain?: string | ||
/** | ||
* API Url to use for the API. | ||
ValentaTomas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
apiUrl?: string | ||
/** | ||
* If true the SDK starts in the debug mode and connects to the local envd API server. | ||
* @internal | ||
|
@@ -78,9 +82,9 @@ export class ConnectionConfig { | |
this.headers = opts?.headers || {} | ||
this.headers['User-Agent'] = `e2b-js-sdk/${version}` | ||
|
||
this.apiUrl = this.debug | ||
? 'http://localhost:3000' | ||
: `https://api.${this.domain}` | ||
this.apiUrl = | ||
opts?.apiUrl ?? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing property that get's the value from the env var. |
||
(this.debug ? 'http://localhost:3000' : `https://api.${this.domain}`) | ||
} | ||
|
||
private static get domain() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.