fix: set Content-Length on presigned PUT uploads for S3 compatibility#1246
fix: set Content-Length on presigned PUT uploads for S3 compatibility#1246mishushakov wants to merge 7 commits intomainfrom
Conversation
S3 presigned PUT URLs do not support Transfer-Encoding: chunked. The JS SDK was streaming the gzipped tar body via fetch without Content-Length, causing 501 NotImplemented on S3-backed deployments. Buffer the compressed tar and set Content-Length explicitly in both JS and Python SDKs. Closes #1235 Closes #1243 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR SummaryMedium Risk Overview In the JS SDK, Written by Cursor Bugbot for commit 4de627c. This will update automatically on new commits. Configure here. |
🦋 Changeset detectedLatest commit: 4de627c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The tar Pack type doesn't expose [Symbol.asyncIterator] in its type definitions, even though it implements it at runtime. Cast through unknown to satisfy the CLI package's stricter typecheck. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Package ArtifactsBuilt from 7499699. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.18.1-mishushakov-fix-sdk-issues.0.tgzCLI ( npm install ./e2b-cli-2.9.1-mishushakov-fix-sdk-issues.0.tgzPython SDK ( pip install ./e2b-2.19.0+mishushakov.fix.sdk.issues-py3-none-any.whl |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 575c2f5f02
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Use a block scope so the chunks array is eligible for GC immediately after Buffer.concat, preventing peak memory from holding both the individual chunks and the concatenated buffer simultaneously. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
The synchronous tar_file_stream call blocks the event loop in the async upload_file function, preventing other coroutines from running during tar creation. Offload to a thread pool via run_in_executor. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
- JS: remove explicit Content-Length header (undici auto-sets it for Buffer bodies; Content-Length is a forbidden Fetch spec header) - Python: use get_running_loop() instead of deprecated get_event_loop() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Can we get some tests verifying the new functionality? |
|
@djeebus I rly don't have a repro here - I am assuming it's self-hosters using regular AWS S3 instead of GCS S3-compatible backend. |
3 participants
Summary
Content-Lengthheader instead of streaming withTransfer-Encoding: chunkedviafetch. Removes theduplex: 'half'workaround.Content-Lengthheader on httpx PUT calls for presigned URL uploads.Transfer-Encoding: chunked, causing501 NotImplementedon self-hosted AWS deployments.Closes #1235
Closes #1243
Test plan
.copy()on a self-hosted AWS (S3) deployment🤖 Generated with Claude Code