Average grades in export #2366
Average grades in export #2366
Conversation
fidoriel
force-pushed
the
average-grades-in-export
branch
3 times, most recently
from
e5117a8 to
d51385d
Compare
fidoriel
force-pushed
the
average-grades-in-export
branch
from
d51385d to
af9697b
Compare
fidoriel
force-pushed
the
average-grades-in-export
branch
from
af9697b to
382680b
Compare
fidoriel
force-pushed
the
average-grades-in-export
branch
from
dced350 to
6163186
Compare
|
|
||
| self.assertEqual( | ||
| float(workbook.sheets()[0].row_values(5)[1]), | ||
| (float(workbook.sheets()[0].row_values(5)[2]) + float(workbook.sheets()[0].row_values(5)[3])) / 2, |
There was a problem hiding this comment.
From a quick glance, it looks like the setup above creates the same exact average result for both evaluations and same count of answers inside of them. This doesn't test whether we compute the average-of-averages with correct weighting. Can we change them to have different answer counts?
Coincidentally, float-equality here made me wonder about correctness. It should work if the two values here are identical, the sum is then 2 * the original value, which is divisible by 2 to perfectly recreate the original value. However, I'd like the test to test a somewhat more sophisticated case. We'll likely need to use assertAlmostEqual then.
There was a problem hiding this comment.
@fidoriel This currently compares a value the system produces against another value that the system produces, which leaves the chance that both might be wrong, but the test still passes.
For a bit more assertiveness, I would appreciate if we could change the assertion here to the exact string that should be shown in the output, optimally in the string-domain (without to-number conversion)
evap/results/tests/test_exporters.py
Outdated
| self.assertEqual(float(workbook.sheets()[0].row_values(8)[1]), float(workbook.sheets()[0].row_values(8)[3])) | ||
| self.assertEqual("", workbook.sheets()[0].row_values(8)[2]) |
There was a problem hiding this comment.
I may be tired, but I don't understand what we're asserting here. What is the intention here? Can we maybe improve the test name or add a comment?
| import_type: Literal[ImportType.PARTICIPANT, ImportType.CONTRIBUTOR] = ( | ||
| ImportType.PARTICIPANT if "participants" in operation else ImportType.CONTRIBUTOR | ||
| ) |
closes #2001