Use middleware for setting language #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
force-pushed
the
uselanguagemiddlewaretoshowusersthatwecare
branch
from
331d2b6 to
9f95a36
Compare
richardebeling
approved these changes
Oct 18, 2021
janno42
approved these changes
Oct 21, 2021
karyon
reviewed
Oct 24, 2021
| @@ -93,7 +93,9 @@ def test_order(self): | |||
| page = self.app.get(self.url, user=student).body.decode() | |||
| self.assertLess(page.index(evaluation1.name_en), page.index(evaluation2.name_en)) | |||
|
|
|||
| page = self.app.get(self.url, user=student, extra_environ={"HTTP_ACCEPT_LANGUAGE": "de"}).body.decode() | |||
There was a problem hiding this comment.
do you know why this doesn't work anymore? shouldn't this run into the "else" branch in your middleware and use what the LocaleMiddleware chose?
If this does not work, does that mean that first-time users will get the default language from evap's settings (and not their browser language?
There was a problem hiding this comment.
line 93 is the first request for this user, so after that, they would have the langauge from that request (english) stored in the database and used, or am I missing something?
First time users should still have their browser language accepted.
|
btw, this also removes evap's usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1631
Instead of setting session and user settings for language when they log in, it is now updated on every request. Now, when a logged in user visits the site with a fresh session, the preference from the database is used.
I couldn't figure out another way to do this easily. An answer to this question also suggests using a third party middleware, https://pypi.python.org/pypi/django-user-language-middleware/. It does the same as this.
One test broke - it used the
HTTP_ACCEPT_LANGUAGEheader. I believe that it was handled by the django locale middleware.Is this a problem? Other thoughts?