Open
Conversation
Collaborator
|
hey @andrewsnowden sorry for the delay in reviewing this (and the other) PR(s). One concern I see here is when images are intentionally left out of the repository, uploaded to S3, from a single machine, and not necessarily on all production machines. We may actually want to do this initial reading and hashing from S3, and not locally. Additionally, we may want to actually update the filename, so for example (very roughly)
or if it hasn't been hashed yet,
any thoughts on this type of approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option that appends file hashes as query strings to static URLs. This forces a refetch if the content changes even if the expiry header has been set far into the future.
Webassets does this for scripts and stylesheets (http://webassets.readthedocs.org/en/latest/expiring.html) but there isn't anything that does it for images.