Skip to content

Conversation

@nandor-magyar
Copy link
Contributor

Memory and CPU limits, both accepting the k8s style input values.

For cpu it's either millicpu (100m) or vcpu (1.5) cores.
For memory it's the binary prefix format: 100Mi, 1Gi.

FYI: in case of docker the if the cpu limit is reached the container is throttled, if the memory limit is reached the container is OOMKilled.

@nandor-magyar nandor-magyar requested a review from a team as a code owner October 30, 2025 11:52
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. lang:golang labels Oct 30, 2025
@m8vago m8vago changed the title feat(dagent): add docker cpu and memory limits feat: add docker cpu and memory limits Oct 31, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 12.28%. Comparing base (bd7135d) to head (ac81af3).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
web/crux/src/grpc/protobuf/proto/agent.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1102      +/-   ##
===========================================
- Coverage    12.29%   12.28%   -0.01%     
===========================================
  Files          303      303              
  Lines        11330    11336       +6     
  Branches      1207     1210       +3     
===========================================
  Hits          1393     1393              
- Misses        9910     9916       +6     
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@m8vago m8vago force-pushed the feat/docker-cpu-memory-limit branch from da64532 to ac81af3 Compare November 5, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:golang pr:feat source:agent The scope of the issue or pull request is agent.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants