Chapter list 'last action' column coloring, hide FB columns #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsapps
changed the title
jakehobbs
approved these changes
Mar 21, 2025
frontend/ChapterList.vue
Outdated
| @@ -754,12 +775,14 @@ export default Vue.extend({ | |||
|
|
|||
| const csrfToken = $('meta[name="csrf-token"]').attr('content'); | |||
| this.disableConfirmButton = true; | |||
| const data = JSON.stringify(this.currentChapter); | |||
| console.log(data); | |||
There was a problem hiding this comment.
purposefully leaving this logging?
There was a problem hiding this comment.
oops thanks, removed
frontend/ChapterList.vue
Outdated
Comment on lines
892
to
896
| const GREEN = 'is-success'; | ||
| const YELLOW = 'is-warning'; | ||
| const RED = 'is-danger'; | ||
| const GRAY = 'is-grey'; | ||
| const BLACK = 'is-black'; |
There was a problem hiding this comment.
nit: could move these to module scope. i would prob do smth like this fwiw:
const Colors = {
GREEN: "is-success",
YELLOW: "is-warning",
...
}
frontend/ChapterList.vue
Outdated
| } else if (time.isAfter(dayjs().subtract(30 * 3.5, 'day'))) { | ||
| return YELLOW; | ||
| } else if (time.isAfter(dayjs().subtract(30 * 4 + 1, 'day'))) { | ||
| // + 1 becauase "black" means the chapter should be offboarded, but |
There was a problem hiding this comment.
nit: typo
Suggested change
| // + 1 becauase "black" means the chapter should be offboarded, but | |
| // + 1 because "black" means the chapter should be offboarded, but |
Updated color ranges based on request from IC (Michelle) and add tooltips for days since last action / days remaining before offboarding.
alexsapps
force-pushed
the
alex/last-action-color
branch
from
92cdeed to
5392cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated color ranges based on request from IC (Michelle) and add tooltips for days since last action / days remaining before offboarding.
Also hide FB columns by default.