Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update auth_plug and jason to highest compatibility (lowest common denominator) versions #25

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nelsonic
Copy link
Member

@nelsonic
Copy link
Member Author

@SimonLab quick one. But no rush. Thanks. 🙏

@nelsonic nelsonic added technical T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #25 (66b6eca) into main (c0016f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files           1        1           
  Lines          46       46           
=======================================
  Hits           45       45           
  Misses          1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic nelsonic changed the title PR: Update auth_plug and jason to latest versions PR: Update auth_plug and jason to highest compatibility (lowest common denominator) versions Oct 18, 2022
@SimonLab
Copy link
Member

I'm not sure why the PR is failing, I tried to rerun the tests but the error is still here:
image

Maybe a CI configuration issue?

@nelsonic
Copy link
Member Author

Yeah, the tests are failing everywhere auth_plug is updated. 🤦‍♂️
I'm addressing via: dwyl/auth#235 🧑‍💻 ⏳ 🙄
Hang tight. 🙏

@nelsonic
Copy link
Member Author

Package published to https://hex.pm/packages/rbac/1.0.3 📦 :shipit:

@nelsonic
Copy link
Member Author

Tests passing on auth and here too. Please review + merge. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review chore T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. technical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants