Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Fix Failing Auth Tests #235

Closed
nelsonic opened this issue Oct 19, 2022 · 3 comments
Closed

Chore: Fix Failing Auth Tests #235

nelsonic opened this issue Oct 19, 2022 · 3 comments
Labels
BLOCKED :fire: Core team's HIGHEST priority, blocking critical work chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. T2h Time Estimate 2 Hours tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

As noted in: #231 (comment)
Tests are still failing on CI ... https://github.com/dwyl/auth/actions/runs/3276606455/jobs/5392858413
image

The good (? 🤷‍♂️ ) news is that they are also failing on my localhost ...

image

This is less interesting than working on features ...
But given that it's BLOCKED progress, it's my priority for the morning ... ⏳
@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies BLOCKED :fire: Core team's HIGHEST priority, blocking critical work T2h Time Estimate 2 Hours tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written labels Oct 19, 2022
This was referenced Oct 19, 2022
Open
Closed
@nelsonic nelsonic added the priority-1 Highest priority issue. This is costing us money every minute that passes. label Oct 20, 2022
@nelsonic
Copy link
Member Author

6 tests failing on localhost ... picking the first one off now. 🧑‍💻 ⏳

nelsonic added a commit that referenced this issue Oct 20, 2022
@nelsonic
tests passing on localhost fixes #235
4744706
@nelsonic
Copy link
Member Author

Is GitHub suuuuper Slow for anyone else? 🤷‍♂️
image

@nelsonic
Copy link
Member Author

Tests finally fixed. ✅

https://github.com/dwyl/auth/actions/runs/3288930149/jobs/5420598380
image

https://github.com/dwyl/auth/actions/runs/3288930149/jobs/5420598380#step:7:247
image

The fix was a loooot simpler than I thought; just updating all the environment variables
and specifically AUTH_API_KEY, AUTH_URL, ENCRYPTION_KEYS and SECRET_KEY_BASE

https://github.com/dwyl/auth/settings/secrets/actions
image

Working now. Back to docs! #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BLOCKED :fire: Core team's HIGHEST priority, blocking critical work chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. T2h Time Estimate 2 Hours tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic