Close Issue #202 #204
Open
Close Issue #202 #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boothby
requested changes
Mar 17, 2022
| vector<int> unscrew(num_vars); | ||
| assert(var_fixed_unscrewed.size() == num_vars); | ||
| assert(num_fixed < num_vars); | ||
| iszero(var_fixed_unscrewed.size() == num_vars); |
Collaborator
There was a problem hiding this comment.
This appears to be a source of problems. Better to change this to minorminer_assert
| virtual ~LocalInteraction() {} | ||
| //! Print a message through the local output method | ||
| void displayOutput(int loglevel, const string& msg) const { displayOutputImpl(loglevel, msg); } | ||
| void displayOutput(int loglevel, const string& msg) const { displayOutputImpl(msg); } |
Collaborator
There was a problem hiding this comment.
Please do not remove loglevel from these functions, as it's used elsewhere in the library. It would be better to add this parameter into the MyCppInteractions overrides and ignore it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for closing Issue #202