Fix the default FrankenPHP Mercure JWT audience - #1
Merged
dunglas merged 2 commits intoSep 7, 2026
Conversation
J3m5
marked this pull request as ready for review
September 7, 2026 16:19
dunglas
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the default JWT audience generated for FrankenPHP's built-in Mercure hub.
When neither
urlnorpublic_urlis configured, the hub is exposed at the root-relative/.well-known/mercureendpoint. The subscriber JWT currently uses that relative URL as itsaudclaim.Mercure protocol 1.0 validates the token audience against the hub resource identifier, which is absolute. For an application served from
https://app.test, the expected audience is therefore:This change derives the default audience from the origin of
app.urlwhile keeping the hub's public URL itself root-relative.Explicit
claims.audandpublic_urlvalues continue to take precedence.The regression coverage includes:
Validation:
This is intended to be merged into the Mercure broadcaster branch used by laravel#61474.