-
Notifications
You must be signed in to change notification settings - Fork 31
History: Stub out support for theming #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 27 Nov 2025 23:55:03 GMT Apple
File has changed Integration
File has changed Windows
File has changed |
|
@noisysocks screenshots failed, indicating you might have changed something that impacts the default/not-implemented case. |
Love it when tests pick up an actual bug! |
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1211842297546424?focus=true
Updates
initialSetupand addsonThemeUpdateto allow setting athemeandthemeVariantper https://app.asana.com/1/137249556945/project/1209121419454298/task/1212083006586484?focus=true.Adjusts the default background colour according to the set variant so that something observable happens when setting a theme.
Marks
customizer.defaultStylesas deprecated.Intention here is to do the minimal amount needed to unblock the native apps. In follow up PRs I’ll import theme variables from the design-tokens repo and update more than just the background colour.
Testing Steps
Checklist
Please tick all that apply:
Note
Adds theming to History (theme and themeVariant) with live updates via onThemeUpdate, schema/type support, CSS variants, mocks, and integration tests.
ThemeProviderand exposedata-themeanddata-theme-varianton the root layout incomponents/App.jsx.global/Providers/ThemeProvider.jsto derive theme from initial setup, system preference, oronThemeUpdate.initialSetupresponse withthemeandthemeVariant.onThemeUpdatesubscription; update generatedtypes/history.tsand JSON schemas.theme/themeVariantand subscription delivery inmock-transport.js.coolGray,slateBlue,green, etc.) updating background variables instyles/history-theme.css.history-theme.spec.jsand helpers to assert theme/variant and background color; include in Playwright config.customizer.defaultStylesis deprecated; usethemeVariantinstead.Written by Cursor Bugbot for commit ca9c553. This will update automatically on new commits. Configure here.