[macOS] - Design feedback fixes for aichat omnibar #2701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements design feedback fixes for the AI Chat omnibar feature on macOS, focusing on visual refinements and bug fixes to improve the user experience.
- Hides the bookmark button when the address bar is focused with AI Chat omnibar enabled
- Adjusts padding and spacing constants to increase input field size
- Fixes placeholder text to only show on the new tab page
- Implements Shift+Enter functionality to insert newlines in duck.ai mode
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AddressBarStyleProviding.swift | Reduced top and bottom padding from 4pt to 3pt for AI Chat focused state to increase input field size |
| SuggestionContainerViewModel.swift | Added early return guards in selectRow and clearRowSelection to prevent unnecessary updates |
| SuggestionViewController.swift | Implemented re-entrancy protection for table selection synchronization to prevent infinite loops |
| AddressBarViewController.swift | Updated placeholder logic to only show AI hint on new tab page; added mode switching interaction tracking |
| AddressBarButtonsViewController.swift | Hidden bookmark button when text field is focused with AI Chat omnibar enabled |
| AddressBarSharedTextState.swift | Added tracking for user interaction after mode switching to preserve newlines correctly |
| MainViewController.swift | Implemented Shift+Enter to insert newline when switching to AI Chat mode |
| MainView.swift | Reduced AI Chat omnibar container minimum height from 100pt to 60pt |
| AIChatOmnibarTextContainerViewController.swift | Adjusted spacing constants and fixed height calculation by removing duplicate inset addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
macOS/DuckDuckGo/NavigationBar/View/AddressBarViewController.swift
Outdated
Show resolved
Hide resolved
macOS/DuckDuckGo/NavigationBar/View/AddressBarViewController.swift
Outdated
Show resolved
Hide resolved
macOS/DuckDuckGo/NavigationBar/View/AddressBarViewController.swift
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aataraxiaa
approved these changes
Nov 30, 2025
Contributor
aataraxiaa
left a comment
aataraxiaa
left a comment
There was a problem hiding this comment.
Tested all scenarios and they work as expected. Left one comment re: reducing some some duplication.
Comment on lines
+925
to
+934
| if case .editing(.aiChat) = controllerMode { | ||
| bookmarkButton.isShown = false | ||
| updateAIChatDividerVisibility() | ||
| return | ||
| } | ||
|
|
||
| if isTextFieldEditorFirstResponder && featureFlagger.isFeatureOn(.aiChatOmnibarToggle) { | ||
| bookmarkButton.isShown = false | ||
| updateAIChatDividerVisibility() | ||
| return |
Contributor
There was a problem hiding this comment.
Should we combine these into one conditional OR statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1204167627774280/task/1212223846179381?focus=true
Description
Fixes:
Testing Steps
Do not show bookmark button when URL is focused
Only display the "Press tab then enter" placeholder on the new tab page
Shift + Enter injects new line on duck.ai
Going back to duck.ai does not removes the new lines
Impact and Risks
Low: Minor visual changes, small bug fixes, improvement to existing features
What could go wrong?
Regressions
Note
Refines AI Chat omnibar UX (layout, keyboard, state sharing) and improves suggestion selection syncing and address bar behavior.
AIChatOmnibarTextContainerViewControllerandMainView(min height now60; bottom padding34; divider top offset-10).insertNewline()to programmatically add newline inAIChatOmnibarTextContainerViewController.MainViewController,Shift/Option+Entertoggles to Duck AI; if switching to AI chat, inject a newline automatically.AddressBarSharedTextState: trackhasUserInteractedWithTextAfterSwitchingModeswith setters/resets; set on text updates.AddressBarViewController: placeholder/hint only on new tab; on mode toggle, restore/share text only if user interacted after switching; force layout after refocus; reset the new interaction flag.AddressBarButtonsViewController: hide bookmark button when the text field is focused and AI Chat toggle is enabled; related visibility updates.SuggestionViewController: replace direct index subscription with sync method; prevent re-entrancy; sync table selection with view model (including default row); guardtableViewSelectionDidChange.SuggestionContainerViewModel: make row-selection APIs robust (bounds checks, no-ops on same selection, coordinatedselectedRowIndex/selectionIndex, optimized clears).CurrentAddressBarStyleProvider(from4to3).Written by Cursor Bugbot for commit cdd44f6. This will update automatically on new commits. Configure here.