PIR: Ensure next scan date is not in the past #2694
+16
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211997685068472?focus=true
Tech Design URL:
CC: @THISISDINOSAUR
Description
This bumps the next scan date to
now()in case it’s connected to an overdue scan.This affects the
scanSchedule.nextScan.datevalue formaintenanceScanStatus.Testing Steps
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Clamps the next scan date to the current time if the earliest preferred run date is in the past and adds a unit test to verify it.
getNextScansInformationinSharedPackages/DataBrokerProtectionCore/Sources/DataBrokerProtectionCore/UIWeb/DBPUICommunicationModelScanStateExtensions.swiftto setnextScan.dateusingmax(earliestScanPreferredRunDate, currentDate).testNextScans_whenPreferredRunDateIsInThePast_thenDisplayDateIsClampedToNowinSharedPackages/DataBrokerProtectionCore/Tests/DataBrokerProtectionCoreTests/DBPUICommunicationViewModelScanStateExtensionsTests.swiftto assertnextScan.date >= now.Written by Cursor Bugbot for commit ef3027c. This will update automatically on new commits. Configure here.