Skip to content

Conversation

@frosty
Copy link
Contributor

@frosty frosty commented Nov 28, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211264967278501/task/1212220916039408
Tech Design URL:
CC:

Description

This PR addresses design feedback for the new data import flows for build v3: https://app.asana.com/1/137249556945/project/1211264967278501/task/1211854974317908

  • Update order of import sources so that CSV and HTML imports come above password managers Asana:
Screenshot 2025-11-28 at 16 24 41
  • Tweaked the Show More button to be just ‘More’, semibold, and same size as the dropdown menu button at the top of the dialog Asana:
Screenshot 2025-11-28 at 16 25 57
  • Expand spacing slightly between padlock and “Encrypted” label Asana:
image
  • Fixed the background color of the ’sync’ area, including in dark mode Asana:
Screenshot 2025-11-28 at 11 52 44 Screenshot 2025-11-28 at 11 48 59
  • Slightly adjust the position of the chevron in the dropdown button Asana:
image
  • Fixed scroll indicators in the summary detail view (previously overlapped the view content) Asana:
Screenshot 2025-11-28 at 15 38 40

Testing Steps

  1. Build and run the Mac app
  2. Ensure the dataImportNewExperience feature flag is enabled
  3. Visit File > Import Bookmarks and Passwords and examine each of the items listed above
  4. To test the scroll indicator in the summary detail screen, I think it’s probably easiest to modify the code to ensure you have a lot of content to scroll:
  • In DataImportSummaryDetailView.swift, comment out lines 46 and 48:
//                        if summary.duplicate > 0 {
                            duplicatesSection(summary: summary)
//                        }
  • Replace the ForEach on line 241 with:
ForEach(1...30, id: \.self) { index in
        duplicateRow(item: ImportItem.password(title: "Title", domain: "example.com", username: "user", errorMessage: nil) )
}
  • Complete an import, such as from Firefox, and click the Details… button next to Passwords on the summary screen.

Impact and Risks

Low: Minor visual changes, small bug fixes, improvement to existing features

Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Cursor Bugbot is generating a summary for commit d17aaaa. Configure here.

@frosty frosty requested a review from amddg44 November 28, 2025 16:45
@github-actions
Copy link

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See iOS and macOS localization guidelines for more information.

Generated by 🚫 dangerJS against d17aaaa

Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@frosty frosty merged commit 69019af into graeme/new-data-import-continued-2 Dec 1, 2025
74 checks passed
@frosty frosty deleted the frosty/data-import-v3-design-fixes branch December 1, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants