[iOS] remove embedded serp settings feature flag

[brindy]

Task/Issue URL: https://app.asana.com/1/137249556945/project/392891325557410/task/1212151280797465?focus=true
Tech Design URL:
CC:

Description

Removes feature flag for embedded SERP settings.

Testing Steps

1. Validate that embedded SERP settings still works.

Impact and Risks

Low: Minor visual changes, small bug fixes, improvement to existing features

What could go wrong?

Could break settings.

Quality Considerations

Notes to Reviewer

---

Internal references:

Definition of Done | Engineering Expectations | Tech Design Template

---

Note

Removes the embedded SERP settings feature flag and always navigates to in-app SERPSettingsView, cleaning up all related flag plumbing.

• Settings UI:
  • iOS/DuckDuckGo/PrivateSearchView.swift: Always show NavigationLink to SERPSettingsView(page: .general); remove web link variant; apply list row background.
  • iOS/DuckDuckGo/SettingsAIFeaturesView.swift: Always show NavigationLinks to SERPSettingsView(page: .searchAssist) and .hideAIGeneratedImages); remove web link variants and associated actions; apply list row backgrounds.
• Feature flags/Config:
  • iOS/Core/FeatureFlag.swift: Remove embeddedSERPSettings case and all references (default values, local overriding support, and source mapping).
  • SharedPackages/.../PrivacyFeature.swift: Remove iOSBrowserConfigSubfeature.embeddedSERPSettings.
  • iOS/DuckDuckGo/SettingsViewModel.swift: Remove embedSERPSettings property.

^{Written by Cursor Bugbot for commit df69b46. This will update automatically on new commits. Configure here.}