Skip to content

Conversation

@alessandroboron
Copy link
Contributor

@alessandroboron alessandroboron commented Nov 28, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211834678943996/task/1211866468574274?focus=true
Tech Design URL:
CC:

Description

Removed the unused feature flag for onboarding add to dock from the codebase. The onboarding add-to-dock feature was released to all users a long time ago, so the feature flag is no longer needed.

Testing Steps

  1. The feature flag was not used anywhere in the codebase so ensure only CI is green.

Impact and Risks

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Removes the unused onboardingAddToDock feature flag and its references from iOS/Core/FeatureFlag.swift.

  • iOS/Core:
    • Remove FeatureFlag.onboardingAddToDock enum case in iOS/Core/FeatureFlag.swift.
    • Drop onboardingAddToDock from supportsLocalOverriding.
    • Remove onboardingAddToDock handling from source mapping.

Written by Cursor Bugbot for commit c268a85. This will update automatically on new commits. Configure here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused onboardingAddToDock feature flag from the iOS codebase. The onboarding add-to-dock feature has been fully rolled out to all users, making the feature flag obsolete.

  • Removed the feature flag enum case and its associated configuration
  • Cleaned up references in local overriding and source mapping
  • Preserved pixel tracking and related functionality (feature remains active, just not flag-gated)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alessandroboron alessandroboron merged commit cb9d52b into main Dec 1, 2025
42 checks passed
@alessandroboron alessandroboron deleted the alessandro/remove-onboarding-add-to-dock-feature-flag branch December 1, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants