[iOS][Feature Flags] Remove Onboarding Highlights flag

[alessandroboron]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211834678943996/task/1211866468468677?focus=true
Tech Design URL:
CC:

Description

Removed the unused feature flag for onboarding highlights from the codebase. The onboarding highlights were released to all users a long time ago, so the feature flag is no longer needed.

Testing Steps

1. The feature flag was not used anywhere in the codebase so ensure only CI is green.

<!—

Testability Challenges

If you encountered issues writing tests due to any class in the codebase, please report it in the Testability Challenges Document

1. Check the Document: First, check the Testability Challenges Table to see if the class you encountered is listed.
2. If the Class Exists:
   • Update the Encounter Count by increasing it by 1.
3. If the Class Does Not Exist:
   • Add a new entry
     —>

Impact and Risks

<!—
What's the impact on users if something goes wrong?

High: Could affect user privacy, lose user data, break core functionality
Medium: Could disrupt specific features or user flows
Low: Minor visual changes, small bug fixes, improvement to existing features
None: Internal tooling, documentation
—>

What could go wrong?

---

Note

Removes the unused onboardingHighlights feature flag and its debug UserDefaults key.

• Core
  • Feature Flags: Remove onboardingHighlights from FeatureFlag, including its entries in supportsLocalOverriding and source.
• Storage
  • UserDefaults: Remove debugOnboardingHighlightsEnabledKey from UserDefaultsWrapper.Key.

^{Written by Cursor Bugbot for commit 6ef2fa4. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

This PR removes the deprecated onboardingHighlights feature flag that was released to all users and is no longer needed in the codebase.

• Removed the onboardingHighlights enum case from FeatureFlag
• Removed the associated debug key debugOnboardingHighlightsEnabledKey from UserDefaultsPropertyWrapper
• Cleaned up all references including the flag's source implementation and its entry in the local override list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
iOS/Core/FeatureFlag.swift	Removed the onboardingHighlights feature flag enum case, its source implementation, and its entry in the local override list
iOS/Core/UserDefaultsPropertyWrapper.swift	Removed the debug key debugOnboardingHighlightsEnabledKey that was associated with the feature flag

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SabrinaTardio]

LGTM!