Disable WebView zoom on Duck.ai pages - #9775
Open
malmstein wants to merge 1 commit into
Open
Conversation
Pinch and double-tap zoom distort the Duck.ai chat layout, which is laid out for a fixed viewport. Zoom is now turned off while a Duck.ai page is showing in a browser tab, reusing the existing Duck.ai page-recognition commands, and turned back on when the tab navigates elsewhere. The contextual sheet WebViews only ever host Duck.ai, so they disable zoom at creation time and never re-enable it. Search result pages are unchanged and still zoom.
malmstein
marked this pull request as ready for review
September 10, 2026 15:06
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1218241023018339
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Pinch and double-tap zoom distort the Duck.ai chat layout, so zoom is now disabled while Duck.ai is showing. In a browser tab this rides the existing
EnableDuckAIFullScreen/DuckAIFullScreenDisabledcommands, so zoom comes back as soon as the tab navigates to any other site. The contextual sheet WebViews only ever host Duck.ai and disable zoom at creation. Search result pages are out of scope here and still zoom.Steps to test this PR
Duck.ai in a browser tab
Duck.ai contextual sheet
Search unaffected
UI changes
No UI changes.
Note
Low Risk
Localized WebView settings toggles around Duck.ai entry/exit with no auth or data-path changes; main regression risk is zoom staying off after leaving Duck.ai in a tab.
Overview
Disables pinch and double-tap zoom on Duck.ai because zoom breaks the chat layout. Regular browsing and SERP zoom behavior are unchanged.
In browser tabs, a new
setWebViewZoomSupportedhelper turns zoom off whenEnableDuckAIFullScreenruns and turns it back on whenDuckAIFullScreenDisabledfires (leaving Duck.ai for another URL).In the contextual Duck.ai sheet, both contextual WebView fragments no longer enable built-in zoom controls and call
setSupportZoom(false)at setup, since those WebViews only load Duck.ai.Reviewed by Cursor Bugbot for commit 2492939. Bugbot is set up for automated code reviews on this repo. Configure here.