Skip to content

add minimal-versions check #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

add minimal-versions check #135

wants to merge 5 commits into from

Conversation

wangfenjin
Copy link
Collaborator

address #134

Change-Id: If82b6798ef1f105449a1bfdad3469fb332fd1178
Change-Id: Id01712311d4573c24dcf3a17fcd9e71eb4646b9e
Change-Id: I3defa9a7f8f4a7327cebb6e8dacfbf94720cade6
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #135 (0882cf6) into main (eebd09f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   58.20%   58.20%           
=======================================
  Files          35       35           
  Lines        2084     2084           
=======================================
  Hits         1213     1213           
  Misses        871      871           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@max-sixty max-sixty mentioned this pull request Jul 9, 2023
@mlafeldt
Copy link
Member

I think the "Address Sanitizer" step already does more than it should right now (running cargo publish --dry-run is not related to sanitizing at all).

I'd like to revisit the need for the job itself (and with it the need for Rust nightly) before adding anything on top.

Closing for now.

@mlafeldt mlafeldt closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants