Apply patches from duckdb/duckdb#644
Merged
Tishj merged 1 commit intoduckdb:v1.4-andiumfrom Jan 12, 2026
Merged
Conversation
Contributor
Author
Collaborator
|
I don't really understand the FIXME comment, I assume this is not something to fix in core, since it wouldnt be a patch otherwise? But what is required in iceberg then? |
Contributor
|
I wrote the patch, without that the autoloading test fail here, and correctly so since there is currently no way to pre-register some logging types to the extension that will declare them. I am not sure if we want to go that way. Alternative would be just adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies patches from duckdb/duckdb:
autoloading_tests.patch