Prefer HOLD-based reweights to prevent rewinding-induced negative edges#86
Merged
Prefer HOLD-based reweights to prevent rewinding-induced negative edges#86
Conversation
1. remove the preference for non-zero augments 2. add a preference for non-zero holds 3. aggregate root buckets for all equal-weight holds (not just zero-weight ones)
ecpeterson
approved these changes
Sep 26, 2025
Contributor
ecpeterson
left a comment
ecpeterson
left a comment
There was a problem hiding this comment.
didn’t read super duper closely, but at a glance i only see one (repeated) style concern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into the following error while running a simulation:
Digging deeper, it like it’s an unfortunately-timed simultaneous reweight and rewind. The rewind causes a negative node to increase in weight, which of course is then not involved in the rewind checking because it is a negative node and therefore doesn’t send pings during scans.
This can (seemingly) be resolved by bumping non-zero HOLDs (aka reweights) in priority and locking root buckets.